Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really deprecate dvcorg/cml-py3 #890

Closed
3 tasks
DavidGOrtega opened this issue Feb 3, 2022 · 12 comments
Closed
3 tasks

Really deprecate dvcorg/cml-py3 #890

DavidGOrtega opened this issue Feb 3, 2022 · 12 comments
Assignees
Labels
cml-image Subcommand documentation Markdown files p0-critical Max priority (ASAP)

Comments

@DavidGOrtega
Copy link
Contributor

DavidGOrtega commented Feb 3, 2022

  • mention the old image is deprecated in the readme & website?
  • update youtube videos?
  • look for popular external blogs?

At LEAST our deprecated image dvcorg/cml-py3:latest does not contain CML.
The biggest problem is that we deprecated this image when many resources and tutorials still uses it.

Run cml --version
/__w/_temp/269a2252-363f-4a5e-9c83-9393827d7f47.sh: 1: /__w/_temp/269a2252-363f-4a5e-9c83-9393827d7f47.sh: cml: not found
Error: Process completed with exit code 127.
@DavidGOrtega DavidGOrtega added cml-image Subcommand p0-critical Max priority (ASAP) labels Feb 3, 2022
@DavidGOrtega DavidGOrtega self-assigned this Feb 3, 2022
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Feb 3, 2022

In fact, cml-py3 images do include an old version of CML that predates #703 and the unified cml command; running cml-send-comment --version for example should work as expected.

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Feb 3, 2022

I wouldn't update those deprecated container images, as per #383 (comment). Instead, this should become a documentation issue to fix all the references to deprecated container images.

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Feb 3, 2022

(Originated in Discord)

@DavidGOrtega DavidGOrtega added the documentation Markdown files label Feb 3, 2022
@DavidGOrtega
Copy link
Contributor Author

We need to avoid this discouraging UX

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Mar 21, 2022

Action points

Footnotes

  1. These are the only matches for cml-py3 in the whole https://github.com/iterative organization.

@0x2b3bfa0
Copy link
Member

🔔 @iterative/cml, worth addressing the second point?

@0x2b3bfa0 0x2b3bfa0 assigned 0x2b3bfa0 and unassigned DavidGOrtega Mar 21, 2022
@omesser
Copy link
Contributor

omesser commented Mar 22, 2022

More to update:

@casperdcl casperdcl changed the title Our deprecated dvcorg/cml-py3:latest does not contain CML Really deprecate dvcorg/cml-py3 Mar 22, 2022
@0x2b3bfa0
Copy link
Member

Linking to #383 (comment) for future references. 🏺 ⛏️ 🏛️

@0x2b3bfa0
Copy link
Member

⚠️ Discord users putting the utterly deprecated cml-py3 container image on their workflows because it's being used on our example repositories, linked from the documentation. Worth a look & some improvements?

@0x2b3bfa0
Copy link
Member

@dacbd helping more users who've watched the videos and encountered this issue 🙈

@dacbd
Copy link
Contributor

dacbd commented May 6, 2022

https://github.com/iterative/setup-tools

@casperdcl casperdcl assigned dacbd and unassigned DavidGOrtega and 0x2b3bfa0 May 10, 2022
@dacbd
Copy link
Contributor

dacbd commented May 11, 2022

Going to get a comment pinned on the culprit youtube videos:

Please note we have deprecated the dvcorg/cml-py3 container image.
You can get the same results with:
 - container: docker://dvcorg/cml-py3:latest
 + steps:
 +   - uses: actions/checkout@v3
 +   - uses: iterative/setup-tools@v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cml-image Subcommand documentation Markdown files p0-critical Max priority (ASAP)
Projects
None yet
Development

No branches or pull requests

4 participants