Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added height prop to toggle tag #3257

Merged
merged 1 commit into from
Feb 9, 2022
Merged

added height prop to toggle tag #3257

merged 1 commit into from
Feb 9, 2022

Conversation

yathomasi
Copy link
Contributor

This will be a simple addition to the current toggle tab on markdown.
We can set a height through a height prop on the toggle component <toggle height="300px"> which will set height for all the tabs.

Ported from pull cml#193

This is added to the gatsby-plugin-iterative-docs plugin.

Solves #3179

@shcheklein shcheklein temporarily deployed to dvc-org-toggle-tab-heig-6vax3f February 4, 2022 12:57 Inactive
@yathomasi yathomasi self-assigned this Feb 4, 2022
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jorgeorpinel jorgeorpinel merged commit 08398dd into master Feb 9, 2022
@jorgeorpinel jorgeorpinel deleted the toggle-tab-height branch February 9, 2022 16:40
iesahin pushed a commit that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants