chore: 🤖 run lint-staged on pre-commit hook

[theashraf]

• remove pretty-quick from pre-commit hooks and replace it with lint-staged
• configure lint-staged linters for .js, .json, .md files
• add format script to format the whole codebase (to be used when needed)

closes #788

[jorgeorpinel]

@theashraf only a few things left to address in #790 (review) and #790 (review). Do you have time to finish this? I can do it if not, no worries. Thanks

[jorgeorpinel]

Looks pretty good! Thanks a lot.

Just waiting to see if we can keep the --bail behavior pretty-quick had as discussed in #790 (comment).

Otherwise, we may have to settle for including a git add task (the developer would not realize that his code was automatically reformatted)... Would this be OK @shcheklein, @iAdramelk?

[iAdramelk]

@jorgeorpinel I think that using git add here is ok. prettier shouldn't try to change anything that will break the code, and I don't see a lot of meaning for the developer to manually check prettier fixes, because we are forcing them anyway. So even if they didn't like the changes, it's not like that they can do something about it.

[jorgeorpinel]

Thanks Alexey. Agree with you again. Let's just see if lint-staged provides a way to "bail", like pretty-quick did. (Waiting for lint-staged/lint-staged/issues/730.) Although, yet another option is simply to keep pretty-quick... I'l check with Ivan directly about this.

[jorgeorpinel]

Changes are all good. Thanks again @theashraf!

But not ready to merge just yet. Waiting on an update. See my #790 (comment) above.

I'll keep an eye on this.

[jorgeorpinel]

UDPATE: The lint-staged guys are actually implementing this 😬 See lint-staged/lint-staged/pull/745

[jorgeorpinel]

So unfortunately the lint-staged guys ended up changing their minds about implementing this so let's keep pretty-quick --bail for now? I think it's important being able to know what you're committing without automatic git add. We can keep this PR alive (will get stale but oh well) to check for future versions of lint-staged though, as they hinted maybe they'll try to implement in a future version.

[jorgeorpinel]

p.s. apologies to @theashraf who was great at submitting this PR. This is very rare that we don't end up merging them, especially when they come from an open issue (which I'm closing for now, BTW).

Abdelrahman, if you're interested in any other issue please feel free to check with me or anyone on the team (#dev-docs channel of our chat) before having a go just so we double check the issue validity. Again, this situation is very rare, in fact it's the first time it happens that I'm aware. But still, sorry!

[shcheklein]

Closing this, @jorgeorpinel , right?

[jorgeorpinel]

OK in that case I'll reopen the issue and relabel it. I guess that makes more sense.