Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdrive: update docs #926

Merged
merged 2 commits into from
Feb 4, 2020
Merged

gdrive: update docs #926

merged 2 commits into from
Feb 4, 2020

Conversation

maxhora
Copy link
Contributor

@maxhora maxhora commented Jan 16, 2020

Fixes #917

Disregard the recommendations below if you use Edit on GitHub button to improve the docs in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This enables GitHub to link the PR to the corresponding bug and close it automatically when PR is merged.

Thank you for the contribution - we'll try to review and merge it as soon as possible. 🙏

@shcheklein shcheklein temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 17, 2020 00:10 Inactive
@shcheklein

This comment has been minimized.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a separate section in the User Guide and put a link to that page here. Too much content for the command reference expandable section, the link to the bottom of the page is confusing (can be probably improved, but it's better just to solve this properly). The flow is not natural - in the create project you already use dvc remote add root/path and explanation to this comes later.

@maxhora

This comment has been minimized.

@shcheklein shcheklein temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 17, 2020 11:28 Inactive
@maxhora

This comment has been minimized.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just a few minor comments to address.

@shcheklein shcheklein temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 18, 2020 21:48 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 18, 2020 21:57 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 19, 2020 16:43 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 19, 2020 16:56 Inactive
@maxhora

This comment has been minimized.

@shcheklein shcheklein temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 19, 2020 22:44 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good iteration! @jorgeorpinel could you try it and give us feedback if it's clear and you was able to setup it? :)

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max. Definitely a great idea to extract this into a separate guide. Here's a first round of my review.

Some of my comments are small language things that I should probably help addressing myself, but I'm spread a little thin today so take a look if you can. Some of them are more general and can apply even to text I didn't specifically mention so they definitely deserve some consideration.

public/static/docs/command-reference/remote/add.md Outdated Show resolved Hide resolved
public/static/docs/command-reference/remote/add.md Outdated Show resolved Hide resolved
public/static/docs/user-guide/setup-google-drive-remote.md Outdated Show resolved Hide resolved
public/static/docs/user-guide/setup-google-drive-remote.md Outdated Show resolved Hide resolved
public/static/docs/user-guide/setup-google-drive-remote.md Outdated Show resolved Hide resolved
public/static/docs/user-guide/setup-google-drive-remote.md Outdated Show resolved Hide resolved
public/static/docs/user-guide/setup-google-drive-remote.md Outdated Show resolved Hide resolved
public/static/docs/user-guide/setup-google-drive-remote.md Outdated Show resolved Hide resolved
public/static/docs/user-guide/setup-google-drive-remote.md Outdated Show resolved Hide resolved
public/static/docs/sidebar.json Outdated Show resolved Hide resolved
@jorgeorpinel

This comment has been minimized.

@shcheklein shcheklein temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 21, 2020 23:04 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 24, 2020 18:36 Inactive
@jorgeorpinel
Copy link
Contributor

Haven't actually tried all the (gdrive ULR formation) options though... Will do that ASAP.

I ran into a bug (iterative/dvc/issues/3235) so I can't actually try the URLs unfortunately. But maybe we should ask other people to try all this anyway @shcheklein? I'll test them once the bug is resolved.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 24, 2020 19:01 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 24, 2020 19:03 Inactive
jorgeorpinel added a commit to maxhora/dvc.org that referenced this pull request Jan 24, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-917-bpsydzzb1cchrh January 24, 2020 19:39 Inactive
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Check some comments around. Did you manage to get access after all?

@shcheklein
Copy link
Member

@jorgeorpinel anything else left here?

@shcheklein
Copy link
Member

@Maxris anything else left, can you resolve/respond to the comments?

@maxhora
Copy link
Contributor Author

maxhora commented Feb 3, 2020

@Maxris anything else left, can you resolve/respond to the comments?

@shcheklein done, have rebased 17 previous commits into single 1 as well.

@shcheklein
Copy link
Member

merging this, @Maxris please create a separate PR with those adjustments you had in mind please.

@maxhora
Copy link
Contributor Author

maxhora commented Feb 4, 2020

@shcheklein going to resolve merging conflict

@maxhora
Copy link
Contributor Author

maxhora commented Feb 4, 2020

@shcheklein done

@shcheklein shcheklein merged commit 0e831a3 into iterative:master Feb 4, 2020
@jorgeorpinel
Copy link
Contributor

anything else left here?

Sorry totally missed track of this one but I see you guys resolved everything. I like with the final result, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd ref: better explain GDrive in remote add
3 participants