Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Consider options to fix links rel/abs mlem_link incosistency #48

Closed
aguschin opened this issue Oct 1, 2021 · 4 comments
Closed

Consider options to fix links rel/abs mlem_link incosistency #48

aguschin opened this issue Oct 1, 2021 · 4 comments
Labels
core Related to things in mlem.core 🏡 housekeeping Fighting technical debt and improving dev process
Milestone
Beta release (dep...

Comments

@aguschin
Copy link
Contributor

aguschin commented Oct 1, 2021

No description provided.

@aguschin aguschin added 🏡 housekeeping Fighting technical debt and improving dev process core Related to things in mlem.core labels Oct 1, 2021
@aguschin aguschin added this to the Beta release milestone Oct 11, 2021
@mike0sv
Copy link
Contributor

mike0sv commented Nov 17, 2021

Which inconsistencies are we talking about? Is it related to #12 ?

@aguschin
Copy link
Contributor Author

This one https://github.com/iterative/mlem/blob/main/mlem/core/objects.py#L273
There was something about changing mlem_link value upon dump(), probably rewriting its value on L286.
The idea was to avoid doing that, but somehow patch it only in mlem.yaml, if I'm not mistaken.

@mike0sv
Copy link
Contributor

mike0sv commented Nov 18, 2021

I don't think it exists after #114

@aguschin
Copy link
Contributor Author

Good, let's close this then!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
core Related to things in mlem.core 🏡 housekeeping Fighting technical debt and improving dev process
Projects
None yet
Milestone
Beta release (deployment)
Development

No branches or pull requests
2 participants
@mike0sv @aguschin