Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could replace more non-word characters #165

Closed
dustinlagoy opened this issue Mar 1, 2024 · 1 comment · Fixed by #166
Closed

Could replace more non-word characters #165

dustinlagoy opened this issue Mar 1, 2024 · 1 comment · Fixed by #166
Labels
enhancement New feature or request external-request You asked, we did shell-bash

Comments

@dustinlagoy
Copy link
Contributor

I have an argparse script which accepts subcommands with names like:

my/first/subcommand
my/second/subcommand

which end up causing invalid completion scripts similar to #20.

It would be trivial to add / to the list of characters replaced in wordify(), or even change the character set to \W to replace any non-word character. Are either of these options preferable? (both work when tested with my script)

I'm happy to put together a one-line pull request if you think this is worthwhile.

@casperdcl
Copy link
Collaborator

Sure, please do open a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external-request You asked, we did shell-bash
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants