Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing a folder during PreferredSort always resets to the first folder in the songwheel #190

Open
SugoiFactory opened this issue Mar 20, 2024 · 2 comments

Comments

@SugoiFactory
Copy link
Contributor

During PreferredSort (favorites), whenever you close a folder, whether through close folder code or by pressing start on the currently open folder, the current selection always jumps back to the first folder in the songwheel. If in ITG folder view instead of IIDX folder view mode, it also jumps back to the first folder when opening a different folder, which is even more jarring.

@nifterific
Copy link

I would like to add to this, the last version where preferred sort works properly is 0.7.0. I had been using that version with the STARLiGHT theme for a while and 0.8.0 gave me no reason to update that particular install since it's improvements wouldn't affect that theme which I use for DDR songs while 0.9.0 and the sync fixes did give me a reason to update. Testing 0.8.0 and 0.9.0 I found that preferred sort not just takes you back to the top folder when opening or closing a folder, it also ignores the folder sort specified in "SongManager PreferredSongs.txt". Song order is respected, however. It is also incredibly laggy for seemingly no reason. I did roll back to 0.7.0 for this set up for now to get around this (0.9.0 works great for my ITG setup). I could get a video if needed.

@CrashCringle12
Copy link
Contributor

Can confirm these are all also the same issues:

#181
Simply-Love/Simply-Love-SM5#553

The issue is how returning to a song is handled, prior to the level and preferred sort changes, it was not possible for a song to exist in multiple sections. The code

The tl;dr is that before i did the stuff for favorites and level sorting, the relationship between song and section was also M:1 (A song belongs to 1 and only 1 section and a section has many songs). So no matter what sort you're in there was only 1 possible section to be returned
With the level sorting and favorites custom sections, a song can appear in multiple sections. So the function that gets the section of a song when you should be in needs to be modified to account for that.

I just got a fix for this I'm testing rn before I make a PR. Should hopefully be in by tn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants