Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox: Add on-background property and deprecate dark property #38

Closed
daneah opened this issue May 25, 2021 · 0 comments · Fixed by #80
Closed

Checkbox: Add on-background property and deprecate dark property #38

daneah opened this issue May 25, 2021 · 0 comments · Fixed by #80

Comments

@daneah
Copy link
Member

daneah commented May 25, 2021

The problem
Many components can be asked to display inverse-style colors using an on-background property. The odd one out is Checkbox, which uses a dark property. The on-background property should be added and preferred instead, for both consistency and decoupling from equating the concept of "dark" to the concept of "on-background."

The solution

  • Add an on-background property that mirrors the current behavior of dark
  • Mark dark as deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant