Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute Exception Handling #29

Closed
luciusism opened this issue Jun 2, 2015 · 3 comments
Closed

Execute Exception Handling #29

luciusism opened this issue Jun 2, 2015 · 3 comments
Labels
enhancement

Comments

@luciusism
Copy link

For the HarvestRestClient.Execute method, when response.StatusCode == System.Net.HttpStatusCode.BadRequest, I suggest throwing the response.Content which includes Harvest's error message.
@ithielnor
Copy link
Owner

Isn't this what we are currently doing? I'll have to look back at this, as I thought I had implemented that.

@ithielnor
Copy link
Owner

Looks like I was only throwing the headers. I've added the content for the next rev.

@ithielnor
Copy link
Owner

I've created a new HarvestException class which exposes the IRestResponse object directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luciusism @ithielnor