Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing invoice with only "from" parameter returns incorrect results #70

Closed
pharrukh opened this issue Jun 2, 2017 · 1 comment
Closed

Comments

@pharrukh
Copy link

pharrukh commented Jun 2, 2017

It might be a mistake of Harvest API but it exists. When passing only "from" parameter, resulting invoices are of dates that are earlier then "from" date.

I prepared a PR with fix: https://github.com/pharrukh/harvest.net/pull/1

@ithielnor
Copy link
Owner

Hi Pharrukh,

I'm not sure I agree with the implementation. You're essentially injecting extra search parameters that the user did not request to work around a bug in Harvest's API. I'd rather let the user decide how they want to do that until such time as Harvest fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants