Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login form name #1

Closed
cckev opened this issue May 26, 2021 · 1 comment
Closed

Login form name #1

cckev opened this issue May 26, 2021 · 1 comment

Comments

@cckev
Copy link

cckev commented May 26, 2021

Looks like Schwab pushed some changes on the front-end of their Login page:
https://www.schwab.com/public/schwab/nn/login/login.html?lang=en

The iframe seems to have been renamed to 'lmsSecondaryLogin'. The current code in schwab.py throws an error:

self.page.frame(name="loginIframe").fill("input[name=\"LoginId\"]", "")

Traceback (most recent call last):
  ...[snipped]...
  File "E:\...\schwab_api\schwab.py", line 101, in login
    self.page.frame(name="loginIframe").fill('input[name="LoginId"]', "")
AttributeError: 'NoneType' object has no attribute 'fill'

Changing all lines with

self.page.frame(name="loginIframe")

to

self.page.frame(name="lmsSecondaryLogin")

should do the trick

Nice work with this library so far. Hoping we'll get an official Schwab API some day...

@itsjafer
Copy link
Owner

itsjafer commented Jun 2, 2021

Thank you for opening up this issue! I've made your suggested change and tested that it works as expected. Appreciate the help :)

@itsjafer itsjafer closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants