Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would you accept a 1.3.0+1.19.2 PR? #8

Open
MerchantPug opened this issue Jun 15, 2023 · 2 comments
Open

Would you accept a 1.3.0+1.19.2 PR? #8

MerchantPug opened this issue Jun 15, 2023 · 2 comments

Comments

@MerchantPug
Copy link

MerchantPug commented Jun 15, 2023 •
edited
Loading

I don't expect you to keep updating it past this PR, because the codebases for dynamic registries diverged a lot ever since, but there's a few vital features missing from where you left off with 1.19.2.

I'm close to finishing a 1.3.0 1.19.2 port for a friend, but I was just wondering if you would be willing to accept it as a one off version bump, mainly so this port is more accessible for those that need it.

The fork can be found here
@itsmiir
Copy link
Owner

itsmiir commented Jun 16, 2023

totally! I don't have the time to backport those features but i know a lot of people use .2

@MerchantPug
Copy link
Author

Alright! I'll send the PR over in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itsmiir @MerchantPug