Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Widget: Add API release tags #448

Closed
grigasp opened this issue Apr 26, 2023 · 0 comments · Fixed by #467
Closed

Tree Widget: Add API release tags #448

grigasp opened this issue Apr 26, 2023 · 0 comments · Fixed by #467
Assignees
Labels
tree widget Tree widget or its components related issues

Comments

@grigasp
Copy link
Member

grigasp commented Apr 26, 2023

At the moment the only difference between public and internal APIs is the barrel export. It's very inconvenient as it makes it hard to know whether a file is exported through the barrel (it may be exported indirectly) and error prone as it's very easy to mistakenly make a function public by adding an internal function to an exported file.

At the very least we should tag our functions. Using API exporter would help us identify possible issues (e.g. public function returning internal type) and track breaking changes in public API.

@grigasp grigasp added the tree widget Tree widget or its components related issues label Apr 26, 2023
@grigasp grigasp added this to the Tree Widget: 1.0 release milestone Apr 26, 2023
@grigasp grigasp self-assigned this May 4, 2023
@grigasp grigasp linked a pull request May 5, 2023 that will close this issue
@grigasp grigasp closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree widget Tree widget or its components related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant