Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit secure_download compose and deploy script #227

Closed
ri-pandey opened this issue Apr 24, 2024 · 1 comment · Fixed by #232
Closed

Commit secure_download compose and deploy script #227

ri-pandey opened this issue Apr 24, 2024 · 1 comment · Fixed by #232
Assignees
Labels
In Development Feature is in active development

Comments

@ri-pandey
Copy link
Contributor

The secure_download runs within Docker containers, but the compose file is missing from the repo. This file can be added to the repo, so developers can look at the config before bothering Operations.

The secure_download's deployment script (deploy.sh) should also be committed to the repo.

@rperigo instead of renaming the compose file, you could keep the docker-compose-prod name and keep it within the /secure_download directory.

@ri-pandey ri-pandey added the In Development Feature is in active development label Apr 25, 2024
@rperigo
Copy link

rperigo commented Apr 26, 2024

I've added an adjusted version of the compose to /secure_download on a new branch (ray_secure_download). There isn't a deploy.sh for this, I simply set the correct UID/GID and such in a .env file and do a docker-compose up. Note: the nginx container is built manually for now for each deployment we have on IU colo nodes - the file has a comment referencing this and it could be moved into the compose directly if desired (and thus use a deploy.sh).

The only Nginx image customization is the creation of the appropriate service account and chowning of files during build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Development Feature is in active development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants