114 and 104 fixes (#148) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "Revert "104 Projects dataset pagination (#113)" (#145)" This reverts commit f4c58d7. * Revert "Revert "114 dynamic search (#122)" (#144)" This reverts commit 7af8f0b. * got search widget working with pagination * reset page index after dataset assignment * some cleaup * fixed responsiveness for widget in stepper * don't show assigned datasets, or ones meant for search, if user doesn't have appropriate access * removed temporary seeding code * some cleanup * allow operators/admins to edit datasets regardless of project-user association * removed comments * check for project-user association if role is user * edited comment * return datasets instead of project-dataset associations included
* return wf info for paginated datasets * fixed property name * fixed return object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is merging the fixes for project-dataset pagination and the new search widget to main, so we can deploy it to CFN-DAP.
Changes Made
List the main changes made in this PR. Be as specific as possible.
Checklist
Before submitting this PR, please make sure that: