77 - make about editable #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* retrieve about text from api * WIP * escape input * switched to markdown-it * fixed some styles * use toast to show errors * size; reset after Cancel * made height fixed; use break-words * changed modal size * changed Edit button * allow users/operators to read * some UI changes * escape input; allow for creation or updating * use popover to indicate syntax * UI changes * added unauthenticated route * cleanup * changed routes; UI changes * WIP * force equal heights; made break-words work * use labels optionally * WIP * changed .gitignore; seed data * WIP - HTML line breaks missing * fixed several styles * fixed spacing; fonts * use constant height across different screen sizes * labels as props * edited seeding code
There was a problem hiding this comment.
Can operators update entries, or is that something only admins can do?
There was a problem hiding this comment.
@deepakduggirala I have added the Edit permission for operators as well. Please approve if all else looks good.
There was a problem hiding this comment.
I have also added a script to populate the base About text when we release to Prod. This script is not part of the 'seed' script - it is it's own one-time script for populating data upon release - here.
deepakduggirala
approved these changes
Feb 29, 2024
deepakduggirala
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made the About page's text editable via a markdown editor.
Related Issue(s)
Closes #77
Changes Made
List the main changes made in this PR. Be as specific as possible.
Feature added
Code refactored
Other changes: [describe]
Made the About page editable via a markdown input.
Persists sanititzed HTML. Upon retrieval, convert persisted HTML to markdown, which can then be edited to updated the About.
Added tabs for mobile view, and side-by-side editor/preview for desktop view.
The HTML generated from real-time markdown-to-HTML conversion is also sanitized.
About Page is globally accessible, but can only be modified by admins and operators.
Endpoints in the about route are authenticated, except
/about/latest.Screenshots (if applicable)
Desktop View
Mobile View
Checklist
Before submitting this PR, please make sure that: