Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

178 fix file browser layout #191

Merged
merged 5 commits into from
Mar 12, 2024
Merged

178 fix file browser layout #191

merged 5 commits into from
Mar 12, 2024

Conversation

deepakduggirala
Copy link
Contributor

@deepakduggirala deepakduggirala commented Mar 11, 2024 •
edited
Loading

Description

  1. Updated UI and API dependencies
  2. Added back "Browse Files" button to dataset and moved download modal button to "Actions" card
  3. UI mobile layout padding adjustment
  4. make reset db script executable bit.

Related Issue(s)

Closes #[178]

image image

ri-pandey
ri-pandey approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@ri-pandey ri-pandey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be more appropriate to check for :disabled="!dataset.is_staged" instead of :disabled="!dataset.num_files"? I know that we have had the num_files check for a while, but given that you added another such line, I felt it worth bringing up.

@deepakduggirala
Copy link
Contributor Author

  1. enable Download button when dataset is staged
  2. Add styles to wrap long file and directory names
image

@deepakduggirala deepakduggirala merged commit 5c272e8 into main Mar 12, 2024
@deepakduggirala deepakduggirala deleted the 178-fix-file-browser-layout branch March 12, 2024 16:09
@deepakduggirala deepakduggirala mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ri-pandey ri-pandey ri-pandey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepakduggirala @ri-pandey