Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Videojs infinite retries / not refreshing #1794

Closed
tenpura-shrimp opened this issue Feb 20, 2021 · 4 comments
Closed

[Bug] Videojs infinite retries / not refreshing #1794

tenpura-shrimp opened this issue Feb 20, 2021 · 4 comments
Labels
bug Something isn't working module:player Impacts the video player of Invidious stale

Comments

@tenpura-shrimp
Copy link

It looks like videojs has infinite retries, and they happen quite rapidly. When the retries go on for a while, the instance will likely get rate limited by google. We should probably limit these or take some other action.

I saw two scenarios where this happened:

  1. Leaving a dash video open for too long, so that the manifest expires. Videojs will retry fetching the chunks but never fetch an updated manifest. This leads to unlimited requests to /videoplayback until the window is closed.
  2. A bad video url gets cached in the database. I'm not sure how this happens in the first place, but if this happens the video player will keep retrying on latest_version until the database gets refreshed.
@tenpura-shrimp tenpura-shrimp added the bug Something isn't working label Feb 20, 2021
@tenpura-shrimp
Copy link
Author

related videojs issues:
videojs/video.js#5849
videojs/http-streaming#1064

@SamantazFox
Copy link
Member

@unixfox that should be fixed now, right?

@unixfox
Copy link
Member

unixfox commented Jun 13, 2022

Not really, I have seen that happening. The thing is that it's not really a bug but more like a feature in order to retry when something fails.

@github-actions
Copy link

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:player Impacts the video player of Invidious stale
Projects
Status: Done
Development

No branches or pull requests

4 participants