Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Allow video duration units to go up to days #4102

Open
syeopite opened this issue Sep 14, 2023 · 5 comments
Open

[Enhancement] Allow video duration units to go up to days #4102

syeopite opened this issue Sep 14, 2023 · 5 comments
Labels
enhancement Improvement of an existing feature module:player Impacts the video player of Invidious

Comments

@syeopite
Copy link
Member

Is your enhancement request related to a problem? Please describe.

Video durations are limited to a maximum unit of hours whereas YouTube supports up to days (but only on the video playback page).

Describe the solution you'd like

For Invidious to support a day unit within the duration. Various other places in Invidious such as the VTT logic would also need to be updated.

Describe alternatives you've considered

Additional context

Youtube:
youtube

Invidious:
invidious
@syeopite syeopite added enhancement Improvement of an existing feature module:watch Watch page-related (other than the player) module:player Impacts the video player of Invidious and removed module:watch Watch page-related (other than the player) labels Sep 14, 2023
@SamantazFox
Copy link
Member

Does Youtube allows VOD that are 200h long? I though they didn't provide VOD for long livestreams!

Also, how big are the odds of finding a 24h+ video on Youtube? Is this change really worth it?

@syeopite
Copy link
Member Author

That particular video isn't actually a VOD. It's a 200 hour timer video https://www.youtube.com/watch?v=mivcDoTjpQE

Does Youtube allows VOD that are 200h long? I though they didn't provide VOD for long livestreams!

They technically do but the VOD would just be in eternal processing (though it could just be because of how long this particular VOD is at over 20k hours...) https://www.youtube.com/watch?v=5qap5aO4i9A

Also, how big are the odds of finding a 24h+ video on Youtube? Is this change really worth it?

It's definitely low priority but a nice quality of life change.

@SamantazFox
Copy link
Member

Loading that page almost crashed my browser :x
Invidious can't play the video in the first place!

@syeopite
Copy link
Member Author

Yep that's a separate issue. See #3220.

The video does eventually load without DASH though.

@SamantazFox
Copy link
Member

Related: FreeTubeApp/FreeTube#1471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature module:player Impacts the video player of Invidious
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SamantazFox @syeopite