Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cost function in MPI runs #12

Closed
1 of 3 tasks
IvanaEscobar opened this issue Jul 8, 2024 · 1 comment · Fixed by #13
Closed
1 of 3 tasks

Cost function in MPI runs #12

IvanaEscobar opened this issue Jul 8, 2024 · 1 comment · Fixed by #13
Assignees
@IvanaEscobar

Comments

@IvanaEscobar
Copy link
Owner

IvanaEscobar commented Jul 8, 2024 •
edited
Loading

ihop cost function accumulation doesn't work with MPI.

This is due to the allocation of dynamic types Arr and ray2D within ihop's core routine BellhopCore. I need to shift memory allocation so it can be seen by all MPI processes.

  • Move Arr and Barr allocation outside of BellhopCore
  • split EvaluateSSP calls from init and task to separate subroutines
  • Remove SSP extraction from readEnviIhop and place directly in ihop_init
@IvanaEscobar IvanaEscobar self-assigned this Jul 8, 2024
@IvanaEscobar IvanaEscobar linked a pull request Jul 9, 2024 that will close this issue
Mpi cost for times of arrival #13
Merged
@IvanaEscobar
Copy link
Owner Author

Address EvaluateSSP changes in a different PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanaEscobar IvanaEscobar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mpi cost for times of arrival IvanaEscobar/ihop
1 participant
@IvanaEscobar