Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dunai-examples: Conformance with style guide #349

Closed
ivanperez-keera opened this issue Mar 6, 2023 · 1 comment
Closed

dunai-examples: Conformance with style guide #349

ivanperez-keera opened this issue Mar 6, 2023 · 1 comment
Labels

Comments

@ivanperez-keera
Copy link
Owner

Description

Several files inside dunai-examples/ are not conformant with our own style guide. These are mainly in the examples directory.

A quick search shows the following potential violations:

3 File structure, no blank lines at top
./list/BouncingBall.hs
./timetransform/TimeTransform.hs
./bouncingball/BouncingBall.hs
./testing.hs
./reversefrpzoo/wormholes/src/Data/MonadicStreamFunction/Wormhole.hs
./classicfrp/Test.hs
./classicfrp/GTest.hs

3.1 Language pragmas must be alphabetized
./timetransform/TimeTransform.hs
./classicfrp/GTest.hs

3.3 All Haskell files must include a copyright notice in a comment
bouncingball/BouncingBall.hs
classicfrp/GTest.hs
classicfrp/Test.hs
discrete/WXStep.hs
discrete/WXText.hs
keerahails/WXText.hs
list/BouncingBall.hs
paper/src/DunaiExamplesExtensibleAFRP.hs
paper/src/DunaiExamplesMonads.hs
paper/src/DunaiExamplesReactiveValues.hs
reversefrpzoo/wormholes/src/Data/MonadicStreamFunction/Wormhole.hs
taggingmonad/Control/Monad/SamplingMonad.hs
taggingmonad/Control/Monad/TaggingMonad.hs
taggingmonad/Data/Maybe/Util.hs
testing.hs
timetransform/TimeTransform.hs

4.3 The column limit for Haskell files is 80 characters
list/BouncingBall.hs
paper/src/DunaiExamplesReactiveValues.hs
timetransform/TimeTransform.hs
bouncingball/BouncingBall.hs
reversefrpzoo/wormholes/src/Data/MonadicStreamFunction/Wormhole.hs
classicfrp/Test.hs
classicfrp/GTest.hs
keerahails/WXText.hs

4.5.2 Vertical Whitespace never allowed at end of file
taggingmonad/Control/Monad/TaggingMonad.hs

4.5.4.2 No trailing spaces
taggingmonad/Control/Monad/TaggingMonad.hs

@ivanperez-keera
Copy link
Owner Author

Closed in favor of #408 and #409.

@ivanperez-keera ivanperez-keera closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant