Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorites button is glitchy #132

Closed
applejag opened this issue May 5, 2022 · 1 comment · Fixed by #141
Closed

Favorites button is glitchy #132

applejag opened this issue May 5, 2022 · 1 comment · Fixed by #141
Assignees
@applejag
Labels
bug Something isn't working good first issue Good for newcomers prio/2 Medium priority. "Good to have"

Comments

@applejag
Copy link
Contributor

applejag commented May 5, 2022 •
edited
Loading

Expected

  • Filled in star when marked as favorite
  • Star border when not marked as favorite

Actual

  • Star border when marked as favorite
  • Star is missing when not marked as favorite

image

^ TestRepo is marked as favorite, and hello-world is not.
@applejag applejag added bug Something isn't working prio/2 Medium priority. "Good to have" labels May 5, 2022
@Alexamakans
Copy link
Member

Alexamakans commented May 5, 2022 •
edited
Loading

Caused by upgrade to PrimeNG v13.3.3.

In v12 it is pi-star for filled, pi-star-o for bordered/outlined.
In v12 it is pi-star-fill for filled, pi-star for bordered/outlined.

For the favorites button this would need to be changed in the getClass method in src/app/projects/project-favorite/project-favorite-button.component.ts.

Additionally, some redundant variants like pi-file-o, which is equivalent to pi-file even in v12, have been removed.
We seem to have used pi-file-o, so this would need to be changed to pi-file as well.

The regex \bpi-\w+?\b should find all uses of these icons.
Will probably need to be compared between v12 and v13 using the lists below to determine the one that was in place earlier.
v12 icon list
v13 icon list

@applejag applejag added the good first issue Good for newcomers label May 5, 2022
@applejag applejag self-assigned this May 9, 2022
@applejag applejag mentioned this issue May 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applejag applejag

Labels
bug Something isn't working good first issue Good for newcomers prio/2 Medium priority. "Good to have"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed favorites button iver-wharf/wharf-web
2 participants
@applejag @Alexamakans