Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of use std::result::Result::Ok; #26

Closed
wants to merge 1 commit into from
Closed

Addition of use std::result::Result::Ok; #26

wants to merge 1 commit into from

Conversation

Hecatron
Copy link
Contributor

Not quite sure how this has been missed unless it's something weird unique to a windows setup for rust.
But I had to add the following lines for this to build
As per #25

@ivmarkov
Copy link
Collaborator

ivmarkov commented Nov 27, 2021

The build of your PR does not pass because of formatting issues (placement of your import is not where it should be).

Anyway, the problem is indeed in latest Rust nightly and not the ldproxy / embuild code. Seems, latest nightly has forgotten, that std::result::Result::Ok is part of the Rust prelude, and as such should not need an import statement.

Shall we fix this? As inconvenient as it is (all ESP-IDF Rust CI pipelines are currently broken!), I suggest we wait for the next nightly. This is such a big issue, that I don't think it will be left open until tomorrow's nightly.

@Hecatron
Copy link
Contributor Author

Hecatron commented Nov 27, 2021

Ah ok, thanks for the info
I thought something didn't feel quite right, I'll close this down in that case.

Although I should mention that I was using rust stable to build embuild at the time
I've tried with both stable and nightly with the same results which is odd since this isn't something building against the esp target.

@Hecatron Hecatron closed this Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants