Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added adaptive max pooling 1D to Ivy backend #22542

Closed
wants to merge 5 commits into from

Conversation

arshPratap
Copy link
Contributor

@arshPratap arshPratap commented Aug 25, 2023

PR Description

Added adaptive max pooling 1D function to ivy backend.
Currently utilized by Torch and Paddle Frameworks
This PR will be followed by another PRs that enables the said function into the designated framework frontends

Related Issue

Close #22317

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API labels Aug 25, 2023
@bipinKrishnan
Copy link
Contributor

Hey @arshPratap , can you fix the failing tests for jax, tf and paddle backends?

@arshPratap arshPratap force-pushed the ivyAdaptiveMaxPool1D branch 3 times, most recently from 915ce1c to 1f3bccc Compare September 11, 2023 08:49
@bipinKrishnan
Copy link
Contributor

@arshPratap The tests in "run_test (1)" are failing due to generated output not matching the ground truth. Can you look into this, fix the conflicts and push again?

@bipinKrishnan bipinKrishnan removed their request for review September 13, 2023 12:25
@ivy-seed
Copy link

ivy-seed commented Oct 9, 2023

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@ivy-seed ivy-seed added the Stale label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@arshPratap
Copy link
Contributor Author

Rebased !

@arshPratap arshPratap changed the title Added adaptive max pooling 1D to Ivy backend feat: Added adaptive max pooling 1D to Ivy backend Oct 24, 2023
@Sarvesh-Kesharwani
Copy link
Contributor

Hi @arshPratap ,
please resolve the merge conflicts so we can proceed with your pull request.

@Ishticode Ishticode assigned Ishticode and unassigned he11owthere Feb 22, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
The logs show failures for the added tests

ivy_tests/test_ivy/test_functional/test_experimental/test_nn/test_layers.py::test_adaptive_max_pool1d,numpy
ivy_tests/test_ivy/test_functional/test_experimental/test_nn/test_layers.py::test_adaptive_max_pool1d,torch
ivy_tests/test_ivy/test_functional/test_experimental/test_nn/test_layers.py::test_adaptive_max_pool1d,paddle
ivy_tests/test_ivy/test_functional/test_experimental/test_nn/test_layers.py::test_adaptive_max_pool1d,jax
ivy_tests/test_ivy/test_functional/test_experimental/test_nn/test_layers.py::test_adaptive_max_pool1d,tensorflow

That you may see at https://github.com/unifyai/ivy/actions/runs/8003861982/job/21860150431?pr=22542
Are you able to fix these? Please let me know if something is unclear.

@Ishticode
Copy link
Contributor

closing due to inactivity for over two weeks after requested changes. Please feel free reopen if you would like to continue working on this. Thanks :)

@Ishticode Ishticode closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adaptive_max_pool1d
9 participants