added adaptive_max_pool1d to frontend and ivy experimental

[sherySSH]

PR Description

Related Issue

Close #22238

Checklist

• Did you add a function?
• Did you add the tests?
• Did you follow the steps we provided?

Socials:

[github-actions]

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

[arshPratap]

Hi @sherySSH
I have already pushed a PR for this here #22542 and was working to implement the solution to this issue. @bipinKrishnan could you take a look here ?

[bipinKrishnan]

@sherySSH Usually you shouldn't make frontend and ivy framework related changes in a single PR, those should be made as a separate PRs to keep things simple and clean.

As @arshPratap mentioned, he had already made a PR on adding this function to ivy last week. Since his PR was created first, he would be continuing the work on adding the function to ivy. You could then make use of this function in the torch frontend you are working on. Again, sorry for the trouble and thanks for the contribution @sherySSH 🙂 .

[sherySSH]

Ok noted. Since frontend was dependent on ivy implementation therefore I thought maybe both of these will go under 1 PR. Thanks for making it clear though, I will keep it under consideration next time.

As soon as, @arshPratap adds function in ivy then I will use it in frontend to complete my sub-task.

Cheers!

[Ishticode]

Hi @sherySSH
Sorry for delays on our end. I will take over the PR and get the other PR mentioned above merged and then get this merged hopefully. The first one implement adaptive 1d max pool in ivy and this PR uses it to impment it in the frontend.
So could you remove the logic from ivy experimental layers as this will just conflict with the updates from the other PR.
Let me know if anything is unclear. Thnx a lot :)

[ivy-seed]

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

[ivy-seed]

This PR has been closed because it has been marked as stale for more than 7 days with no activity.