Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TreeBuilder generic #53

Open
iwburns opened this issue Oct 8, 2017 · 0 comments
Open

Make TreeBuilder generic #53

iwburns opened this issue Oct 8, 2017 · 0 comments
Labels
enhancement

Comments

@iwburns
Copy link
Owner

iwburns commented Oct 8, 2017

TreeBuilder has been split out into VecTreeBuilder and OptTreeBuilder, but this is very likely unnecessary.

It would be nicer if we had a single TreeBuilder (back to the original name) that knew how to build both types of trees instead of repeating all of the same logic in two different places.
@iwburns iwburns changed the title Make TreeBuilder Generic Make TreeBuilder generic Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iwburns