Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Mod Add-on #10

Closed
A5ho9999 opened this issue Apr 6, 2023 · 5 comments
Closed

[Question] Mod Add-on #10

A5ho9999 opened this issue Apr 6, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@A5ho9999
Copy link
Contributor

A5ho9999 commented Apr 6, 2023

I've spent the past couple days working on a small addition to the Mod at the request of some people for colouring Allays but also to make it possible to dye the squids. Just wanted to ask if you'd be willing to accept such an addon for the Mod. I was going to also look at adding _jeb however I'd like to avoid using the nametag to rather let people have actual names without changing the appearance and wasn't sure the best way to do that yet.

I can create a pull request if you are happy with it.

Changes

  • Adds Coloured Allays
  • Adds Dye Usage for both Squid and Allay
  • Adds all Default Minecraft Colours (for Dye support)
@ix0rai
Copy link
Member

ix0rai commented Apr 6, 2023

that would be lovely, thank you!

after your pull request goes through, I'll lock each entity behind a config option (enable rainbow glow squids, enable rainglow allays, etc). I'd also like to look into implementing rainbow slimes.

one thing to consider for adding dye usage is how it'll interact on all three sides (server, client, integrated server). the mod targets all three, so just make sure to disable dye usage cleanly when the mod is only present on the client.

@ix0rai ix0rai added the enhancement New feature or request label Apr 6, 2023
@A5ho9999
Copy link
Contributor Author

A5ho9999 commented Apr 6, 2023

Yes, I did think about the config options but figured I'd leave that as I'm not the best with the Config Screens.

I'll double check the dye on a server real quick before making the request

@ix0rai
Copy link
Member

ix0rai commented Apr 6, 2023

I'll do any additional polish I feel is necessary for release, don't worry about adding it to the configuration file yourself

@A5ho9999
Copy link
Contributor Author

A5ho9999 commented Apr 6, 2023

Double checked and didn't notice any issues with Mod only being client side, the dye function works but doesn't consume the dye from the player. Does consume when it's on both.

@ix0rai
Copy link
Member

ix0rai commented Apr 6, 2023

hm, I think that's fine since in the client side only case the player is the only one seeing their squids anyway. thank you again for working on this!

@ix0rai ix0rai closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants