Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] crash from upstream error #645

Closed
leihao opened this issue Jun 13, 2024 · 1 comment
Closed

[Bug] crash from upstream error #645

leihao opened this issue Jun 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@leihao
Copy link

leihao commented Jun 13, 2024

Describe the bug

When an upstream code error occurs, the program crashes and exits, unable to continue queuing for downloading other files, and unable to retain incomplete downloaded files.
gotd/td#1030

To Reproduce

tdl dl -u ...

Expected behavior

Give up the failed task, continue queuing, retain the incomplete files, and look forward to resuming the download next time.

Version

Version: 0.17.1
Commit: 7f4e543
Date: 2024-05-29T14:50:17Z

go1.21.10 linux/amd64

Which OS are you running tdl on?

Windows

Additional context

Error: group:
github.com/gotd/td/mtproto.(*Conn).Run
github.com/gotd/td@v0.102.0/mtproto/conn.go:214

  • task readLoop:
    github.com/gotd/td/tdsync.(*LogGroup).Go.func1
    github.com/gotd/td@v0.102.0/tdsync/log_group.go:48
  • read:
    github.com/gotd/td/mtproto.(*Conn).readLoop
    github.com/gotd/td@v0.102.0/mtproto/read.go:193
  • read:
    github.com/gotd/td/transport.(*connection).Recv
    github.com/gotd/td@v0.102.0/transport/connection.go:70
  • read intermediate:
    github.com/gotd/td/proto/codec.Intermediate.Read
    github.com/gotd/td@v0.102.0/proto/codec/intermediate.go:73
  • read length:
    github.com/gotd/td/proto/codec.readLen
    github.com/gotd/td@v0.102.0/proto/codec/codec.go:35
  • EOF
@leihao leihao added the bug Something isn't working label Jun 13, 2024
@iyear
Copy link
Owner

iyear commented Jun 13, 2024

#158 (comment)

@iyear iyear closed this as completed Jun 13, 2024
@iyear iyear added the duplicate This issue or pull request already exists label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants