Fixed setup.py to install deps #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the install_requires line needed to install pypi dependencies and opportunistically fixed the usage of `summary` which isn't recognized by dist/setuptools and used `description` instead.
DeepCode's analysis on #3dd161 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
nineinchnick
approved these changes
Sep 22, 2020
Following the convention here https://packaging.python.org/guides/making-a-pypi-friendly-readme/#including-your-readme-in-your-package-s-metadata to move beyond the CI error.
nineinchnick
approved these changes
Sep 22, 2020
|
Thanks! Interesting though, the previous version was passing Github CI checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the install_requires line needed to install pypi dependencies and
opportunistically fixed the usage of
summarywhich isn't recognized bydist/setuptools and used
descriptioninstead.