Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge graph edges #76

Merged
merged 1 commit into from
Mar 3, 2020
Merged

merge graph edges #76

merged 1 commit into from
Mar 3, 2020

Conversation

nineinchnick
Copy link
Collaborator

Allow to collapse a request and response dataflow into a single double-arrow edge. This greatly simplifies bigger DFDs and makes them more (actually) readable.

Added 3 new Dataflow attributes:

  • isResponse - bool, when set and there's exactly one other dataflow for the same source and sink in reversed direction treat it as the request
  • responseTo - point to another dataflow that this one is a response to
  • response - point to another dataflow that's a response to this one

If only one of those attributes is set, others are filled in automatically, when possible.

When TM.mergeResponses is set, the resulting DFD would look like:
dfd

Possibly closes #53

@ghost
Copy link

ghost commented Feb 26, 2020

DeepCode's analysis on #b9aa55 found:

  • 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@izar
Copy link
Collaborator

izar commented Feb 26, 2020

Wow, I don't know. To me it makes it harder to read. Let me ask the rest of the team what they think.

@nineinchnick
Copy link
Collaborator Author

The example might be too simple. It works better for large models, especially when there are multiple data flows between one pair of assets. Also note this is optional and not enabled by default.

@izar izar merged commit 4069259 into OWASP:master Mar 3, 2020
@nineinchnick nineinchnick deleted the merge-edges branch March 12, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bidirectional dataflows
2 participants