Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threat matching methods #82

Merged
merged 1 commit into from
Mar 19, 2020
Merged

threat matching methods #82

merged 1 commit into from
Mar 19, 2020

Conversation

nineinchnick
Copy link
Collaborator

Add a set of methods to Elements to make more complex Threat conditions remain readable.

@nineinchnick nineinchnick requested a review from izar as a code owner March 5, 2020 17:42
@ghost
Copy link

ghost commented Mar 5, 2020

DeepCode's analysis on #5cb153 found:

  • 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 1 issue were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@nineinchnick nineinchnick force-pushed the threat-matching branch 6 times, most recently from 50fe5fb to 00b525d Compare March 15, 2020 20:56
Copy link
Collaborator

@izar izar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful! Can you document them on the README, since they go beyond using the attributes ? I'll merge after that. Thanks!

@nineinchnick
Copy link
Collaborator Author

I updated the README, check it out in the branch view at https://github.com/nineinchnick/pytm/tree/threat-matching

@izar izar merged commit 4a25881 into OWASP:master Mar 19, 2020
@nineinchnick nineinchnick deleted the threat-matching branch March 19, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants