Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move authenticateDestination to base Element #88

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

nineinchnick
Copy link
Collaborator

Move authenticateDestination to base Element and make Dataflows inherit it from sources to properly model when clients do/don't verify server certificates.

@nineinchnick nineinchnick requested a review from izar as a code owner March 17, 2020 10:28
@ghost
Copy link

ghost commented Mar 17, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.503 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Copy link
Collaborator

@izar izar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add this to CHANGELOG as I think it breaks existing scripts silently.

@izar izar merged commit e92e106 into OWASP:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants