Merge pull request #121 from samhocevar-forks/fix-invalid-po-generation

Ensure empty previous values for msgid and msgstr are properly saved.

polib.py

@@ -1053,7 +1053,7 @@ def __unicode__(self, wrapwidth=78):
             prefix = "#| "
         for f in fields:
             val = getattr(self, f)
-            if val:
+            if val is not None:
                 ret += self._str_field(f, prefix, "", val, wrapwidth)
 
         ret.append(_BaseEntry.__unicode__(self, wrapwidth))

tests/test_previous_msgid.po

@@ -18,3 +18,10 @@ msgstr ""
 #| msgid "Partition table entries are not in disk order2\n"
 msgid "The new msgid2"
 msgstr ""
+
+
+#| msgctxt "Some other message context"
+#| msgid ""
+msgctxt "The new msgctxt3"
+msgid "The new msgid3"
+msgstr ""

tests/tests.py

@@ -149,6 +149,23 @@ def test_previous_msgid_2(self):
             expected
         )
 
+    def test_previous_msgid_3(self):
+        """
+        Test saving empty previous msgid.
+        """
+        po = polib.pofile('tests/test_previous_msgid.po')
+        fd, tmpfile = tempfile.mkstemp()
+        os.close(fd)
+        po.save(tmpfile)
+        po = polib.pofile(tmpfile)
+        os.remove(tmpfile)
+
+        expected = ""
+        self.assertEqual(
+            po[2].previous_msgid,
+            expected
+        )
+
     def test_previous_msgctxt_1(self):
         """
         Test previous msgctxt multiline.