Ensure empty previous values for msgid and msgstr are properly saved. #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents polib from creating illegal pofiles (that have
#| msgctxt
but not#| msgid
).Here is a simple way to witness the behaviour:
before.po
test.py
Result
By running
test.py
you can observe that the#| msgid ""
line has disappeared. This makes the.po
file invalid, and tools such as e.g.msgmerge
will no longer be able to open it. For instance: