Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote filenames containing whitespace in argument to SyncTeX if called via 'exec'. #95

Merged
merged 1 commit into from
Nov 22, 2015

Conversation

xax
Copy link

@xax xax commented Nov 17, 2015

See issue #91.

This patch is not thoroughly tested, as I do not have the opportunities to do that right now (– that being the reason I opened an issue instead of posting a pull request in the first place).

And you can think of other approaches to tackle the issue, too: Unconditionally quote, quote entire clickspec argument, quote upon other characters as well…

@l0calh05t
Copy link

It would be better to just shell escape clickspec in its entirety. That way only the exec version would be affected by the code changes. node-shell-escape could be used for this purpose (although it might not be suitable for windows.. linux and windows escaping are different).

@izuzak izuzak merged commit 7465abc into izuzak:master Nov 22, 2015
izuzak added a commit that referenced this pull request Nov 22, 2015
@izuzak
Copy link
Owner

izuzak commented Nov 22, 2015

Thanks for opening a pull request. 🍰 I cleaned this up a bit and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants