Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Korean translations #59

Closed
izzy opened this issue Oct 4, 2020 · 6 comments · Fixed by #65
Closed

Add Korean translations #59

izzy opened this issue Oct 4, 2020 · 6 comments · Fixed by #65
Assignees
@gaurav219
Labels
Hacktoberfest translation

Comments

@izzy
Copy link
Owner

izzy commented Oct 4, 2020

See #24
@izzy izzy mentioned this issue Oct 4, 2020
Open
44 tasks
@gaurav219
Copy link
Contributor

Hey @izzy, I'll go with the Korean translation

@gaurav219
Copy link
Contributor

Also, just a quick Q, Do I have to translate according to their alphabets or to the english alphabets only??

@izzy
Copy link
Owner Author

izzy commented Oct 4, 2020

The messages should end up written in Hangul apart from stuff that you wouldn't translate anyways like the name of the extension or technical terms. I think Russian and Greek are both okay examples who followed that to different degrees.

@gaurav219
Copy link
Contributor

Hey!! In French, description is also translated but in others it is in English only!!

So, do we leave the description part or it is optional??

@izzy
Copy link
Owner Author

izzy commented Oct 4, 2020

The description field is just a comment for translators and never used anywhere else, so you don't need to translate that. It's probably best to just leave it in English.

@izzy izzy linked a pull request Oct 4, 2020 that will close this issue
Added Korean Translation #65
Merged
@izzy
Copy link
Owner Author

izzy commented Oct 4, 2020

Thanks for the translation! ✨

@izzy izzy closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaurav219 gaurav219

Labels
Hacktoberfest translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Korean Translation gaurav219/d3coder
2 participants
@izzy @gaurav219