Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make org.jooq.impl.CombinedCondition a binary expression #10710

Closed
lukaseder opened this issue Oct 2, 2020 · 1 comment
Closed

Make org.jooq.impl.CombinedCondition a binary expression #10710

lukaseder opened this issue Oct 2, 2020 · 1 comment
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement
Milestone
Version 3.16.0

Comments

@lukaseder
Copy link
Member

Changing org.jooq.impl.Expression to be a binary expression solved a few bugs related to accidental mutability (see #10665). It also greatly simplified transformations (#10054).

Perhaps, similar gains can be achieved by turning CombinedCondition to a binary expression. CombinedCondition is probably used more often, so a close look at our benchmarks before / after this change would be interesting as well.
@lukaseder lukaseder added this to the Version 3.15.0 milestone Oct 2, 2020
@lukaseder lukaseder mentioned this issue Sep 13, 2021
Closed
93 tasks
@lukaseder lukaseder changed the title Consider making org.jooq.impl.CombinedCondition a binary expression Make org.jooq.impl.CombinedCondition a binary expression Sep 13, 2021
@lukaseder
Copy link
Member Author

This is a prerequisite for the new query object model: #12425

lukaseder added a commit that referenced this issue Sep 13, 2021
@lukaseder
[#10710] Make org.jooq.impl.CombinedCondition a binary expression
8c6efab
@lukaseder lukaseder mentioned this issue Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement
Projects
None yet
Milestone
Version 3.16.0
Development

No branches or pull requests
1 participant
@lukaseder