Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change jOOQ-meta Relations.getUniqueKeys() to return unique keys only #10884

Closed
lukaseder opened this issue Nov 6, 2020 · 0 comments
Closed

Change jOOQ-meta Relations.getUniqueKeys() to return unique keys only #10884

lukaseder opened this issue Nov 6, 2020 · 0 comments
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Enhancement T: Incompatible change
Projects
3.13 DDL interpretation
Milestone
Version 3.15.0

Comments

@lukaseder
Copy link
Member

lukaseder commented Nov 6, 2020 •
edited

There is some confusion throughout the jOOQ API if a "unique key" includes primary keys or only actual UNIQUE constraints.

For consistency reasons, we should change the jOOQ-meta method Relations::getUniqueKeys to produce unique keys only, not primary keys. Likewise, there should be getKeys() methods that return both primary and unique keys.

See also:
@lukaseder lukaseder added this to the Version 3.15.0 milestone Nov 6, 2020
@lukaseder lukaseder added this to To do in 3.13 DDL interpretation via automation Nov 6, 2020
3.13 DDL interpretation automation moved this from To do to Done Nov 6, 2020
lukaseder added a commit that referenced this issue Nov 6, 2020
@lukaseder
[#10546] [#10883] [#10884]
c4c7272 
- [#10546] Add { Schema, Meta } . { getUniqueKeys(),
getForeignKeys(), getIndexes() }
- [#10883] Add Table.getUniqueKeys()
- [#10884] Change jOOQ-meta Relations.getUniqueKeys() to return
unique keys only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Enhancement T: Incompatible change
Projects
3.13 DDL interpretation
  
Done
Milestone
Version 3.15.0
Development

No branches or pull requests
1 participant
@lukaseder