Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser should parse all Names.* values at least once #11232

Closed
22 of 73 tasks
lukaseder opened this issue Jan 14, 2021 · 1 comment
Closed
22 of 73 tasks

Parser should parse all Names.* values at least once #11232

lukaseder opened this issue Jan 14, 2021 · 1 comment

Comments

@lukaseder
Copy link
Member

lukaseder commented Jan 14, 2021

We probably have a few more functions that we know how to render but not parse, like #11231.

A new test should be able to discover all Names.* identifiers, and heuristically try to parse them using some common syntax, e.g. iterate through ASCII(null), ASCII(null, null), etc. and assert that at least one syntax parses just fine. This isn't a robust unit test, there are enough other tests. But this test serves to discover accidental omissions.

The improvements thus discovered will be listed here:

Trivial cases

Moved to separate issue

To be reviewed

  • ADD_DAYS
  • ADD_MONTHS
  • ADD_SECONDS
  • ARRAY_LENGTH
  • COLLECT
  • COUNTSET
  • CURRENT_BIGDATETIME
  • DATALENGTH
  • DATEADD
  • DATEPART
  • DATE_ADD
  • DATE_DIFF
  • DATE_TRUNC
  • DAYS
  • DAYS_BETWEEN
  • GEN_ID
  • HASHBYTES
  • ISJSON
  • JSONB_AGG
  • JSONB_BUILD_ARRAY
  • JSONB_OBJECT
  • JSONB_OBJECTAGG
  • JSONB_OBJECT_AGG
  • JSONB_PATH_EXISTS
  • JSONB_PATH_QUERY_FIRST
  • JSON_AGG
  • JSON_BUILD_ARRAY
  • JSON_CONTAINS_PATH
  • JSON_EXTRACT
  • JSON_MERGE
  • JSON_OBJECT_AGG
  • JSON_QUOTE
  • JSON_TABLE
  • JSON_VALID
  • LENGTHB
  • LIST
  • LISTAGG
  • NANO100_BETWEEN
  • RAWTOHEX
  • RND
  • SCHEMA_NAME
  • SECONDS_BETWEEN
  • STANDARD_HASH
  • STATS_MODE
  • STRFTIME
  • STRING_AGG
  • TIMESTAMPADD
  • TO_CLOB
  • USER
  • WEEKDAY
  • ZEROBLOB
@lukaseder
Copy link
Member Author

This is an ongoing task and doesn't need to be kept as an open issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant