You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The kotlin extensions module jOOQ-kotlin contains a few inline functions, some of which have reified generics. Both language features are unnecessary, and discouraged in our case by the kotlin compiler via warning:
Expected performance impact from inlining is insignificant. Inlining works best for functions with parameters of functional types
The runtime overhead of removing inline seems negligible as this only affects query building, not execution let alone data type binding, but there might be some impact on the compiler? (I couldn't measure any significant difference when compiling code generation integration tests, but maybe, in user projects, there's still a difference).
I don't see why this could be causing backwards compatibility issues in user code. Both keywords aren't really required, unless we need to reflect on a T::class.java type.
The text was updated successfully, but these errors were encountered:
The kotlin extensions module
jOOQ-kotlin
contains a fewinline
functions, some of which havereified
generics. Both language features are unnecessary, and discouraged in our case by the kotlin compiler via warning:The runtime overhead of removing
inline
seems negligible as this only affects query building, not execution let alone data type binding, but there might be some impact on the compiler? (I couldn't measure any significant difference when compiling code generation integration tests, but maybe, in user projects, there's still a difference).I don't see why this could be causing backwards compatibility issues in user code. Both keywords aren't really required, unless we need to reflect on a
T::class.java
type.The text was updated successfully, but these errors were encountered: