Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "inline" and "reified" keywords from jOOQ-kotlin extensions where unnecessary #13540

Closed
lukaseder opened this issue May 9, 2022 · 1 comment

Comments

@lukaseder
Copy link
Member

The kotlin extensions module jOOQ-kotlin contains a few inline functions, some of which have reified generics. Both language features are unnecessary, and discouraged in our case by the kotlin compiler via warning:

Expected performance impact from inlining is insignificant. Inlining works best for functions with parameters of functional types

The runtime overhead of removing inline seems negligible as this only affects query building, not execution let alone data type binding, but there might be some impact on the compiler? (I couldn't measure any significant difference when compiling code generation integration tests, but maybe, in user projects, there's still a difference).

I don't see why this could be causing backwards compatibility issues in user code. Both keywords aren't really required, unless we need to reflect on a T::class.java type.

@lukaseder
Copy link
Member Author

Unfortunately, this doesn't seem to fix #13338

lukaseder added a commit that referenced this issue May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant