Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultRecordBinding.pgRenderRecordCast and others don't apply schema mapping #13762

Closed
6 tasks done
lukaseder opened this issue Jul 5, 2022 · 3 comments
Closed
6 tasks done

Comments

@lukaseder
Copy link
Member

lukaseder commented Jul 5, 2022

There are quite a few jOOQ internals that use a Named::getQualifiedName and render that directly, without giving schema mapping any consideration. One example is DefaultRecordBinding.pgRenderRecordCast, which might not apply schema mapping.

We should have an ExecuteListener in our integration tests that looks for references of the default schema in ordinary generated SQL (e.g. public), and then tries applying a schema mapping public -> xyz, to check if all public references have been replaced correctly by xyz). With that ExecuteListener added to every integration test, we'll have much higher test coverage of the schema mapping feature.

The above test has exposed the following missing schema mappings (at least):

@lukaseder lukaseder added this to the Version 3.18.0 milestone Jul 5, 2022
@lukaseder lukaseder changed the title DefaultRecordBinding.pgRenderRecordCast doesn't apply schema mapping DefaultRecordBinding.pgRenderRecordCast and others don't apply schema mapping Jul 5, 2022
@lukaseder
Copy link
Member Author

I'll treat this as an umbrella issue to fix all sorts of missing schema mapping applications, see updated issue description

@lukaseder
Copy link
Member Author

The UDT stuff has changed a bit in jOOQ 3.17, which is why I won't backport the fix to 3.16 and older minor releases...

@lukaseder
Copy link
Member Author

Fixed in jOOQ 3.18.0 and 3.17.2 (#13765)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant