Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JooqLogger.isErrorEnabled() #15051

Closed
lukaseder opened this issue May 10, 2023 · 1 comment
Closed

Add JooqLogger.isErrorEnabled() #15051

lukaseder opened this issue May 10, 2023 · 1 comment
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement
Projects
3.19 Other improvements
Milestone
Version 3.19.0

Comments

@lukaseder
Copy link
Member

The JooqLogger currently doesn't have a isErrorEnabled() check. So far, there hasn't been any reason to do this, but perhaps there is one with:

For consistency reasons, it would make sense to implement all the log suppression mechanisms that are available for the other log levels also for ERROR
@lukaseder lukaseder added this to the Version 3.19.0 milestone May 10, 2023
@lukaseder lukaseder added this to To do in 3.19 Other improvements via automation May 10, 2023
@lukaseder lukaseder mentioned this issue May 10, 2023
Closed
lukaseder added a commit that referenced this issue May 10, 2023
@lukaseder
[#15050] Add support for generic
d5ad7d2 
org.jooq.log.<logger>=threshold system properties

This includes:

- [#15051] Add JooqLogger.isErrorEnabled()
- [#15052] JooqLogger log methods don't check if log level is
enabled
@lukaseder
Copy link
Member Author

Implemented in jOOQ 3.19.0.

3.19 Other improvements automation moved this from To do to Done May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement
Projects
No open projects
3.19 Other improvements
Done
Milestone
Version 3.19.0
Development

No branches or pull requests
1 participant
@lukaseder