Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JooqLogger log methods don't check if log level is enabled #15052

Closed
lukaseder opened this issue May 10, 2023 · 1 comment
Closed

JooqLogger log methods don't check if log level is enabled #15052

lukaseder opened this issue May 10, 2023 · 1 comment

Comments

@lukaseder
Copy link
Member

The various JooqLogger.trace(), debug(), info(), warn(), error() methods don't re-check if the log level is enabled. They rely on the logging backend to do this correctly. But there can be other reasons why the logger is disabled, including:

The globalThreshold is already verified. So, this bug doesn't really affect a lot of users, except those who use reflection. It became apparent only when implementing #15050. Thus, there's no need for a backport.

@lukaseder lukaseder added this to the Version 3.19.0 milestone May 10, 2023
@lukaseder lukaseder added this to To do in 3.19 Other improvements via automation May 10, 2023
lukaseder added a commit that referenced this issue May 10, 2023
org.jooq.log.<logger>=threshold system properties

This includes:

- [#15051] Add JooqLogger.isErrorEnabled()
- [#15052] JooqLogger log methods don't check if log level is
enabled
@lukaseder
Copy link
Member Author

Implemented in jOOQ 3.19.0. As the driving reason for this fix (#15050) won't be backported, this fix also won't be backported.

3.19 Other improvements automation moved this from To do to Done May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant