Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaWriter uses regex syntax unsupported in Java <1.8 #4576

Closed
dbichko opened this issue Sep 24, 2015 · 6 comments
Closed

JavaWriter uses regex syntax unsupported in Java <1.8 #4576

dbichko opened this issue Sep 24, 2015 · 6 comments

Comments

@dbichko
Copy link

dbichko commented Sep 24, 2015

JavaWriter.java in 3.6.3, line 121:

Matcher m = Pattern.compile("(?s:^.*?\\Rpackage\\s+(.*?);?\\R.*?$)").matcher(string);

\R is new in 1.8, which I don't believe is explicitly required for jOOQ.

@lukaseder
Copy link
Member

Thank you very much for reporting this! This is a regression introduced with #4229 (#4230).

The linebreak matcher \R corresponds to "Any Unicode linebreak sequence, which is equivalent to \u000D\u000A|[\u000A\u000B\u000C\u000D\u0085\u2028\u2029]"

It was indeed introduced in Java 8 only, and must thus not be used in jOOQ for backwards compatibility.

@lukaseder
Copy link
Member

This will be merged to 3.6.4 as #4583

@lukaseder
Copy link
Member

Fixed for jOOQ 3.7. We'll hopefully be able to publish a fix by Tuesday this week in 3.6.4.

@lukaseder
Copy link
Member

This is now fixed and published also in 3.6.4

@dbichko
Copy link
Author

dbichko commented Sep 29, 2015

Thanks for the really quick fix!

@lukaseder
Copy link
Member

You're welcome. This was a real show-stopper...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants