Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull up DAOImpl.getId() to DAO.getId() #7874

Closed
lukaseder opened this issue Sep 20, 2018 · 0 comments
Closed

Pull up DAOImpl.getId() to DAO.getId() #7874

lukaseder opened this issue Sep 20, 2018 · 0 comments
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement T: Incompatible change
Milestone
Version 3.12.0

Comments

@lukaseder
Copy link
Member

lukaseder commented Sep 20, 2018 •
edited
Loading

Users may find the implementation of the DAOImpl.getId() method useful, especially when working with composite keys. There's little harm in making this method public, and available from the interface DAO. We already have similar "getters", like DAO.getTable() and DAO.getType().

This qualifies as an incompatible change as all generated code has to be re-generated to make implementations public as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement T: Incompatible change
Projects
None yet
Milestone
Version 3.12.0
Development

No branches or pull requests
1 participant
@lukaseder