Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java generator always uses LF line terminator for import statements #9276

Closed
knutwannheden opened this issue Sep 26, 2019 · 3 comments
Closed

Java generator always uses LF line terminator for import statements #9276

knutwannheden opened this issue Sep 26, 2019 · 3 comments
Assignees
@knutwannheden
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Enhancement
Milestone
Version 3.13.0

Comments

@knutwannheden
Copy link
Contributor

The code generator can be configured to use CRLF line terminators rather than LF. This works, but for the import list the Java generator still uses LF terminators, which is inconsistent.
@knutwannheden knutwannheden added this to the Version 3.13.0 milestone Sep 26, 2019
@knutwannheden knutwannheden self-assigned this Sep 26, 2019
lukaseder added a commit that referenced this issue Sep 26, 2019
@lukaseder
[#9276] Consistently use same line terminators in generator
f1568d4 
Also for the import list the Java / Scala generators now use the
configured line terminator rather than a hardcoded  terminator.
@knutwannheden
Copy link
Contributor Author

I think we should also downbranch this to 3.12. @lukaseder What do you think?

@lukaseder
Copy link
Member

Yeah sure, why not.

@knutwannheden knutwannheden mentioned this issue Oct 15, 2019
Closed
@knutwannheden
Copy link
Contributor Author

This will be backported to 3.12.2 with #9377.

knutwannheden added a commit that referenced this issue Oct 16, 2019
@knutwannheden
[#9276] Consistently use same line terminators in generator
d3df06d 
Also for the import list the Java / Scala generators now use the
configured line terminator rather than a hardcoded `LF` terminator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knutwannheden knutwannheden

Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Enhancement
Projects
None yet
Milestone
Version 3.13.0
Development

No branches or pull requests
2 participants
@knutwannheden @lukaseder