Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor & clean up CSS #16

Closed
josephfusco opened this issue Oct 1, 2016 · 5 comments
Closed

Refactor & clean up CSS #16

josephfusco opened this issue Oct 1, 2016 · 5 comments

Comments

@josephfusco
Copy link
Contributor

No description provided.

@ja1984
Copy link
Owner

ja1984 commented Oct 2, 2016

Anything in particular you can point at that could be refactored?

@josephfusco
Copy link
Contributor Author

josephfusco commented Oct 3, 2016 •
edited
Loading

  • Mix of soft tabs and hard tabs (I'd suggest using hard tabs here)
  • Consistency with indentation
  • Certain properties seems unnecessary
filter: brightness(100%);
-webkit-filter: brightness(100%);

^ What is the reason for this on the icons?

@alxlark alxlark mentioned this issue Oct 3, 2016
Merged
@ja1984
Copy link
Owner

ja1984 commented Oct 3, 2016

Fixed with #21

@ja1984 ja1984 closed this as completed Oct 3, 2016
@josephfusco
Copy link
Contributor Author

@ja1984 I am still wondering what the point of this is https://github.com/ja1984/jackbox/blob/master/jackbox.css#L48-L49 ? 😊

@ja1984
Copy link
Owner

ja1984 commented Oct 4, 2016

@josephfusco Haha, that shouldn't be in there! ;) I removed it in #26 , and thought I had removed it in main branch as well.

It will get removed once my pull request is cleared ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ja1984 @josephfusco