Use new jsoncpp reader #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Json::Reader is deprecated and will fail polybar compilation Fixes polybar/polybar#741
patrick96
force-pushed
the
reader_deprecated
branch
from
4e9cd24
to
c5d73cb
Compare
This was referenced Nov 30, 2017
|
I have tested this a little but since I do not use i3 as my regular workspace, the test was in no way comprehensive. But I think the jsoncpp people made sure the |
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Dec 3, 2017
Actual fix was made in polybar/i3ipcpp#4 this only updates the submodule Fixes polybar#741 Fixes polybar#871
|
Totally forgot about testing this before merging, but this also works with jsoncpp 1.7.7 that ships with i3ipcpp, so it should also work for all versions in between (hopefully) |
patrick96
added a commit
to polybar/polybar
that referenced
this pull request
Dec 3, 2017
Actual fix was made in polybar/i3ipcpp#4 this only updates the submodule Fixes #741 Fixes #871
thelema
reviewed
Feb 8, 2018
| } | ||
| { \ | ||
| Json::CharReaderBuilder b; \ | ||
| Json::CharReader* reader(b.newCharReader()); \ |
There was a problem hiding this comment.
Yeah, probably does. I'm gonna open a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Json::Reader is deprecated and will fail polybar compilation
EDIT: I still have to test if the new function call still works the same
Fixes polybar/polybar#741 and polybar/polybar#871