Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: MPRIS module #456

Closed
wants to merge 16 commits into from
Closed

WIP: MPRIS module #456

wants to merge 16 commits into from

Conversation

andrzejressel
Copy link
Contributor

@andrzejressel andrzejressel commented Feb 22, 2017

This pull requests adds MPRIS module suggested here: #84 (comment).

Basic stuff (song name/artist, pausing, stopping works). I must find a way to generate .c and .h from .xml in CMake and logic must be also reviewed. I was also thinking about combining mpd and mpris modules, but there seems to be a lot of logic differences.

TODO:

  • Fix memory leaks
  • Generate .c with dbus at compile time
  • Implement Shuffle
  • Implement Position

@andrzejressel andrzejressel changed the title WIP: MPRIS support WIP: MPRIS module Feb 22, 2017
@jaagr
Copy link
Member

jaagr commented Feb 22, 2017

I will check out the pr later today. As for the logic of the mpd module you should probably ignore it as it's rather messy.

@fa7ad
Copy link

fa7ad commented Nov 2, 2017

bump any update on this?

@Lomadriel
Copy link
Member

Hello @jereksel,
Do you still want to work on this feature?
If you don't want, I'll continue to implement that feature.

@andrzejressel
Copy link
Contributor Author

@Lomadriel
Feel free to take it, I don't use polybar anymore.

@patrick96
Copy link
Member

@Lomadriel another idea we had was to implement a playerctl module. It's interface is a lot simpler than implementing the whole of the MPRIS spec

Ref: https://github.com/polybar/polybar/projects/1#card-10511466

@fa7ad
Copy link

fa7ad commented May 17, 2019

@patrick96 Yeah, that's what I (and most other people I know) use right now. A custom module that runs a playerctl based script periodically.

@Lomadriel
Copy link
Member

Hum okay, this might be a good idea but my goal was to add dbus into polybar to allow to use other bus interface like for example upower (to fix the battery problems).
I didn't know that playerctl had an api (I always thought it was just a command line program)

@patrick96
Copy link
Member

@Lomadriel I think you can agree with me that we should postpone this until we are done with some of the major refactoring. I am also wondering if it might not be a little overkill to add DBUS for only the backlight.

@Lomadriel
Copy link
Member

@Lomadriel I think you can agree with me that we should postpone this until we are done with some of the major refactoring. I am also wondering if it might not be a little overkill to add DBUS for only the backlight.

Yeah that's what I was planning to do, I think it is better to wait (at least) until we split polybar in modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants