Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1072 Working preferences questions #1135

Merged
merged 47 commits into from
Jul 1, 2024
Merged

#1072 Working preferences questions #1135

merged 47 commits into from
Jul 1, 2024

Conversation

warrensearle
Copy link
Member

@warrensearle warrensearle commented Jan 23, 2024 •
edited
Loading

What's included?

Improvements to the working preferences questions, as follows:

  • Working preferences questions should be mandatory (if configured)
  • Ranking. Should not be able to skip numbers - e.g. choosing two answers from five means user can choose 1st and 2nd choice, not 1st and 5th
  • There can now be multiple location questions.
  • There can now be multiple jurisdiction questions.
  • SETs can configure how many answers candidates should select (for multiple & ranked choices)
  • Questions can be linked together so answering one question, with a particular answer, means a follow-on question is asked
  • To aid navigation answers can now be grouped together
  • Review page should display answers

Closes #1072
Closes #1162

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

This should be tested alongside jac-uk/admin#2207.

We decided to continue to support current functionality for existing exercises and have new exercises benefit from the new functionality.

There are therefore two areas to test:

1. There should not be any breaking changes for existing exercises

Pick an existing exercise configured with original working preferences functionality (use the existing exercise chosen/created in part 1 of testing this PR)

Create an application and in particular check that working preferences questions can be answered and edited.
Before submitting your application check that preference answers are correctly displayed on the Review screen.

Please highlight any breaking changes.

2. New exercises should benefit from the new functionality and the new functionality satisfies user requirements

Use the new exercise created in part 2 of testing this PR

Create a new application and in particular complete all of the Working preferences questions and review your answers.

Please highlight any issues with, or suggestions for, the new functionality.

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8849161):

https://jac-apply-develop--pr1135-feature-1072-working-bfvlilog.web.app

(expires Wed, 31 Jul 2024 14:20:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ac0a9c931657844a433a502135cf38aca21627

@warrensearle warrensearle marked this pull request as ready for review January 29, 2024 15:04
@warrensearle warrensearle requested review from a team as code owners January 29, 2024 15:04
@warrensearle warrensearle requested review from NormaJAC, tomlovesgithub, drieJAC, KoWeiJAC and nickaddy and removed request for drieJAC January 29, 2024 15:04
nickaddy
nickaddy approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warrensearle Looking good! Let's put to UT this week and see what the users have to say :-)

HalcyonJAC
HalcyonJAC requested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality works for me. @Franceswog spotted that there is a validation issue on "Date of birth" on the "Create an account" page but it works well on develop. It might be related to the changes of FormField.vue. Could you check it, please?

Screenshot 2024-02-02 at 13 48 43

@nickaddy
Copy link
Contributor

nickaddy commented Feb 6, 2024 •
edited by drieJAC
Loading

@warrensearle Passed UT, but need to factor in some input from Matt:

  • Equal ranking is inconsistent, e.g. it is possible to select 1,1,1,2 (correct), but it is also possible to select 1,1,1,3 and 1,1,1,4 - only the first option should be possible and bearing in mind we will be sending this info to JO in the Deployment report, it needs to be clear and logical

@warrensearle warrensearle mentioned this pull request May 29, 2024
Merged
6 tasks
@warrensearle
Copy link
Member Author

warrensearle commented Jun 3, 2024 •
edited
Loading

I propose closing this ticket and moving any future changes or bugs to new tickets.

Note that I have re-opened the following two tickets as the described functionality needs to be updated with changes/simplifications made in this pull request:

jac-uk/admin#2318

jac-uk/admin#2319

I have also created a new bug ticket here:

#1178

@warrensearle
Copy link
Member Author

@nickaddy please can you approve this PR, particularly if you agree with the above suggestion

@warrensearle warrensearle merged commit 137e29e into main Jul 1, 2024
4 checks passed
@warrensearle warrensearle deleted the feature/1072-working-preferences branch July 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlovesgithub tomlovesgithub tomlovesgithub approved these changes

@HalcyonJAC HalcyonJAC HalcyonJAC approved these changes

@drieJAC drieJAC drieJAC approved these changes

@nickaddy nickaddy nickaddy approved these changes

@KoWeiJAC KoWeiJAC Awaiting requested review from KoWeiJAC KoWeiJAC is a code owner automatically assigned from jac-uk/halcyon

@NormaJAC NormaJAC Awaiting requested review from NormaJAC

Assignees

@warrensearle warrensearle

Labels
Passed UT
Projects
None yet
Milestone
No milestone
7 participants
@warrensearle @nickaddy @NormaJAC @Franceswog @drieJAC @tomlovesgithub @HalcyonJAC